CLDR-19275 move webdriver to be a proper subproject#5463
CLDR-19275 move webdriver to be a proper subproject#5463
Conversation
- change webdriver main to be a main() instead of a test - allow webdriver to inherit versions from parent
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
cldr-next | 946e409 | Commit Preview URL Branch Preview URL |
Mar 14 2026, 12:43 AM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
cldr-next | 9675f7d | Commit Preview URL Branch Preview URL |
Mar 14 2026, 12:53 AM |
|
builds, doesn't work yet. |
How does it fail? Should I investigate? |
|
@btangmu you can see the failure https://github.com/unicode-org/cldr/actions/runs/23076569629/job/67038129961#step:11:26 - i think I just didn't wire up the test properly yet. THe point of this is to normalize the webdriver's build so it's part of the other projects, rather than separate (as if it were still in a separate repo) so that it can benefit from dependency updates etc. It had its own copy of the spotless config for example. |
|
There are error messages from setup-config.sh involving /tmp/cldr-code.jar -- not clear whether these are central to the main failure. setup-config.sh runs in cldr-apps/Dockerfile, not cldr-apps-webdriver/Dockerfile. So it's cldr-apps, not cldr-apps-webdriver, that fails here. That suggests the error is "invalid address of the remote server" rather than "browser start-up failure". This command has two parts:
Seems like it's the second part ( |
| # See tools/cldr-apps/README.md | ||
| run: > | ||
| docker compose run -v ~/.m2/repository:/root/.m2/repository:rw --rm webdriver || ( docker compose exec -it cldr-apps tail /logs/messages.log ; true ) | ||
| docker compose run --rm webdriver || ( docker compose exec -it cldr-apps tail /logs/messages.log ; true ) |
There was a problem hiding this comment.
org.openqa.selenium.SessionNotCreatedException "Could not start a new session. Possible causes are invalid address of the remote server or browser start-up failure." caused by java.nio.channels.ClosedChannelException "I/O operation on a channel that has already been closed"
|
Why is it that webdriver runs before cldr-apps? Could cldr-apps start first instead? |
2 participants
The PR #5403 pointed out that we have two copies of the spotless machinery. This starts to reduce that.
CLDR-19275
ALLOW_MANY_COMMITS=true